Skip to content

Fixed an issue where multiple Tools with FunctionDeclarations#56

Merged
gunpal5 merged 1 commit intogunpal5:mainfrom
trapezoid:fix_mea_multiple_aifunction
Jul 21, 2025
Merged

Fixed an issue where multiple Tools with FunctionDeclarations#56
gunpal5 merged 1 commit intogunpal5:mainfrom
trapezoid:fix_mea_multiple_aifunction

Conversation

@trapezoid
Copy link

@trapezoid trapezoid commented Jul 21, 2025 •
edited by coderabbitai bot
Loading

Fixed an issue where multiple Tools with FunctionDeclarations generated when multiple AIFunction were defined, causing Gemini to return 400.
Now only a single Tool is generated.

Summary by CodeRabbit

  • Refactor
    • Updated the way tools are structured and aggregated within content generation requests for improved organization. No changes to user-facing functionality.

Fixed an issue where multiple Tools with FunctionDeclarations were ge…
02ffeed 
…nerated when multiple AIFunction were defined, causing Gemini to return 400. Now only a single Tool is generated.
@coderabbitai
Copy link

coderabbitai bot commented Jul 21, 2025 •
edited
Loading

Walkthrough

The code refactors the way AI function tools are assigned within the ToGenerateContentRequest method. Instead of assigning a list of Tool objects for each function, it now aggregates all function declarations into a single Tool object, updating the internal structure of request.Tools.

Changes

File(s) Change Summary
src/GenerativeAI.Microsoft/Extensions/MicrosoftExtensions.cs Refactored tool assignment logic: aggregates all function declarations into a single Tool object rather than multiple Tool objects.

Estimated code review effort

2 (10–30 minutes)

Poem

In the garden of code where the functions bloom,
Tools once scattered now gather in one room.
A single bouquet, neat and bright,
Declares all functions in unified light.
Rabbits hop by, their whiskers a-twitch,
Cheering the order—what a clever switch! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 21, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/GenerativeAI.Microsoft/Extensions/MicrosoftExtensions.cs (1)

56-65: Fix addresses the issue correctly, but remove redundant ToList().

The logic correctly creates a single Tool containing all function declarations, which should resolve the Gemini 400 error. However, there's a redundant ToList() call since functionDeclarations is already a List<FunctionDeclaration>.

Apply this diff to remove the unnecessary list copy:

-                    FunctionDeclarations = functionDeclarations.ToList()
+                    FunctionDeclarations = functionDeclarations
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dec1c1b and 02ffeed.

📒 Files selected for processing (1)
  • src/GenerativeAI.Microsoft/Extensions/MicrosoftExtensions.cs (1 hunks)
🔇 Additional comments (1)
src/GenerativeAI.Microsoft/Extensions/MicrosoftExtensions.cs (1)

47-54: LGTM: Clean transformation logic.

The code correctly transforms AIFunction objects into FunctionDeclaration objects with proper null handling and clear variable naming.

@gunpal5 gunpal5 merged commit 0cc85eb into gunpal5:main Jul 21, 2025
1 check passed
@dependabot dependabot bot mentioned this pull request Jul 28, 2025
Merged
This was referenced Dec 3, 2025
Closed
Closed
This was referenced Jan 16, 2026
Closed
Closed
Closed
This was referenced Jan 28, 2026
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trapezoid @gunpal5